solace-samples-nodejs icon indicating copy to clipboard operation
solace-samples-nodejs copied to clipboard

Payload compression

Open gszol opened this issue 1 year ago • 6 comments

Simple payload compression sample. Copy-paste of the prov-deprov sample.

gszol avatar May 09 '24 19:05 gszol

Just curious - I maybe wrong. Compression is available only for SMF. How do we test whether the payload is getting compressed or not (maybe a before and after length log would help)

As a sample run does not indicate a clear impact of compression:

Session subscribed to topic, sending message with a thousand bytes, all the same
Message received. Payload length:1000
TX bytes:1048
RX bytes:1048

gvensan avatar May 16 '24 12:05 gvensan

Here's the output if you run it against a solclientJS build that supports compression, e.g. /home/public/RND/loads/solclientjs/js_compression_payload/current/external/npm-solclientjs-10.15.2-dev-js-compression-payload.7569.tar.gz

Payload compression should be transport independent BTW.

[gszokoli@dev2-28 js_samples]$ node src/features/PayloadCompression.js tcp://c36p default@default default
Connecting to Solace PubSub+ Event Broker using url: tcp://c36p
Client username: default
Solace PubSub+ Event Broker VPN name: default
Session up, subscribing.
Session subscribed to topic, sending message with a thousand bytes, all the same
Message received. Payload length:1000
TX bytes:114
RX bytes:114

gszol avatar May 16 '24 13:05 gszol

Hi @gszol - When is this planned to be released?

gvensan avatar Jul 18 '24 05:07 gvensan

Hi @gszol - When is this planned to be released?

Looks like we just released it with 10.17.0 : https://products.solace.com/download/JS_API_RN

gszol avatar Jul 18 '24 11:07 gszol

@gszol if this is ready to be merged can you change it from a draft PR?

Mrc0113 avatar Aug 06 '24 13:08 Mrc0113

@gszol if this is ready to be merged can you change it from a draft PR?

I though I have, sorry. Now I again think I just did, I guess we'll see.

gszol avatar Aug 06 '24 13:08 gszol

Is there anything blocking this PR? Can we merge it.....

gvensan avatar Oct 09 '24 08:10 gvensan

Is there anything blocking this PR?

Not to my knowledge.

Can we merge it.....

Yes, please do. (I don't have write access.)

gszol avatar Oct 09 '24 12:10 gszol