adminjs icon indicating copy to clipboard operation
adminjs copied to clipboard

[Bug]: Delete action guard show "modal-subTitle"

Open Physium opened this issue 1 year ago • 3 comments

Contact Details

No response

What happened?

As reference in this comment here: https://github.com/SoftwareBrothers/adminjs/commit/3a3961cb173ade4575c5394d13605ed348f066f7#commitcomment-146217694

Documentation lacks any explanation on how to configure this "modal-subTitle" and even so it seems un-configurable when tracing the code back to build-action-click-handler.js.

It seems to me that the default translations were missed out the list here, adding modal-subTitle with a value of sort fixes this.

Bug prevalence

Everytime

AdminJS dependencies version

adminjs 7.8.12

What browsers do you see the problem on?

No response

Relevant log output

No response

Relevant code that's giving you issues

No response

Physium avatar Oct 14 '24 17:10 Physium

Thanks for opening the issue. Like I mentioned slightly in the comment - would be nice to have an option to configure the submodal message by passing an accordingly parameter. 'guard' doesn't seem to cover this entirely.

malteamlimit avatar Oct 14 '24 22:10 malteamlimit

@dziraf the subtitle property in modalProps is missing

https://github.com/SoftwareBrothers/adminjs/blob/262fa77163747f6dd340fbeffcbf46386801edf1/src/frontend/interfaces/action/build-action-click-handler.ts#L46-L57

wtime avatar Nov 09 '24 09:11 wtime

+1

hexploitable avatar Dec 04 '24 22:12 hexploitable