Highlights icon indicating copy to clipboard operation
Highlights copied to clipboard

Coroutines support

Open tmaxxdd opened this issue 1 year ago • 5 comments

tmaxxdd avatar Sep 22 '24 08:09 tmaxxdd

@Nek-12 Maybe you would like to have a look on this work. I worked with coroutines some time ago

tmaxxdd avatar Sep 22 '24 10:09 tmaxxdd

Want me to propose another variant of the API?

Nek-12 avatar Sep 22 '24 10:09 Nek-12

Want me to propose another variant of the API?

Yes please

tmaxxdd avatar Sep 22 '24 10:09 tmaxxdd

You are making a lot of changes, should I still work on this?

Nek-12 avatar Sep 26 '24 07:09 Nek-12

I have applied some of your suggestions and only changed small things like unit tests.

I don't know if you have branched from commit, copied code or created new branch from scratch.

I am experimenting and testing this code with Dart and Swift.

If you plan to make big changes in API create a separate PR even if this is this branch based

tmaxxdd avatar Sep 26 '24 18:09 tmaxxdd

@Nek-12 Hi, did you manage to create any POC? :)

tmaxxdd avatar Oct 06 '24 14:10 tmaxxdd

Hi, I assumed that since you are making changes I should wait 😅. Can you help me understand how you want that to be done? Should I fork and open another PR into release/1.0.0 or into this branch?

Nek-12 avatar Oct 08 '24 05:10 Nek-12

Okay 😄

I tried creating a public API with Kotlin Flow but this works best when client side also implements Flow library and this is not my intention.

Nevertheless I am very happy to see your approach. Please create a PR pointing to release/1.0.0 with your idea. Grab the enough amount of code from me or write from scratch ;)

tmaxxdd avatar Oct 08 '24 09:10 tmaxxdd