dndserver icon indicating copy to clipboard operation
dndserver copied to clipboard

Added schema for Item management

Open Bakk-f4 opened this issue 2 years ago • 2 comments

let me know what you think about this schema

Bakk-f4 avatar Apr 25 '23 23:04 Bakk-f4

Looks pretty good. Some remarks, I dont think we need both the userId and characterId. The inventory is part of the character.

Another thing but that is just my preference. I would shorten the "item_perk_one, item_perk_two, etc" to "perk0, perk1, perk2, etc"

itzandroidtab avatar Apr 25 '23 23:04 itzandroidtab

It is probably necessary due to the possibility of having multiple characters associated with the same userID. But if the character ID is a primary key independent of the userID association, we can remove the need to validate the userID.

felipefcunica avatar Apr 26 '23 17:04 felipefcunica

@Bakk-f4 could you wait for the alembic merge and generate the revision file ?

Example: alembic revision --autogenerate -m "Added items table"

FilippoLeone avatar Apr 27 '23 09:04 FilippoLeone