easy-thumbnails icon indicating copy to clipboard operation
easy-thumbnails copied to clipboard

using sorl-thumbnail and easy-thumbnails side-by-side

Open stefanfoulis opened this issue 9 years ago • 5 comments

see https://github.com/mariocesar/sorl-thumbnail/issues/445

stefanfoulis avatar Feb 25 '16 14:02 stefanfoulis

@SmileyChris If we were to provide a PR for such a change, would you merge it?

stefanfoulis avatar Feb 10 '17 14:02 stefanfoulis

@SmileyChris @stefanfoulis Any updates on this?

mfcovington avatar Nov 11 '17 16:11 mfcovington

@stefanfoulis I am in favor for your renaming proposal. However, we must assure that there is a warning, if someone uses the old naming convention.

jrief avatar Nov 12 '17 13:11 jrief

I'm cool with this too.

I think rather than deprecating the common settings name for both packages would be to just check for the installation of both packages and then fail, requiring the unique settings names. If someone is only using the one package, there's no real urgency for it to be renamed.

On Mon, 13 Nov 2017 at 02:40 Jacob Rief [email protected] wrote:

@stefanfoulis https://github.com/stefanfoulis I am in favor for your renaming proposal. However, we must assure that there is a warning, if someone uses the old naming convention.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SmileyChris/easy-thumbnails/issues/401#issuecomment-343738054, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGtf27ZMKGywPDiGBviiUHBgIgiG7-3ks5s1vVLgaJpZM4HiztM .

SmileyChris avatar Nov 12 '17 22:11 SmileyChris

Cool. Then it is relatively clear what to do. :-) Unfortunately, I won't have time to make this PR in the next months.

stefanfoulis avatar Nov 14 '17 09:11 stefanfoulis