SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

Add support for the Water Valve Matter 1.3 device type

Open nickolas-deboom opened this issue 1 year ago • 3 comments

Check all that apply

Type of Change

  • [ ] WWST Certification Request
    • If this is your first time contributing code:
      • [ ] I have reviewed the README.md file
      • [ ] I have reviewed the CODE_OF_CONDUCT.md file
      • [ ] I have signed the CLA
    • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [ ] Bug fix
  • [X] New feature
  • [ ] Refactor

Checklist

  • [X] I have performed a self-review of my code
  • [X] I have commented my code in hard-to-understand areas
  • [ ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This PR adds support for the Water Valve, a new Matter 1.3 device type. See this page for documentation on which clusters and capabilities were determined to be MVP for this device type.

Note that test cases are not yet included so I have marked this PR as work in progress.

Summary of Completed Tests

nickolas-deboom avatar Jul 22 '24 19:07 nickolas-deboom

Channel deleted.

github-actions[bot] avatar Jul 22 '24 19:07 github-actions[bot]

Test Results

   61 files  ±0    377 suites  +1   0s :stopwatch: ±0s 1 814 tests  - 7  1 774 :white_check_mark:  - 47  0 :zzz: ±0  0 :x: ±0  40 :fire: +40  3 163 runs   - 7  3 102 :white_check_mark:  - 68  0 :zzz: ±0  0 :x: ±0  61 :fire: +61 

For more details on these errors, see this check.

Results for commit 82a9dc54. ± Comparison against base commit 732e42a3.

This pull request removes 7 tests.
Test profile change on init for Room AC device type
Test profile change on init for color dimmer parent cluster as server
Test profile change on init for dimmer parent cluster as server
Test profile change on init for onoff device when parent and child are both server
Test profile change on init for onoff parent cluster as client
Test profile change on init for onoff parent cluster as client and onoff child as server
Test profile change on init for onoff parent cluster as server

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 22 '24 19:07 github-actions[bot]

File Coverage
All files 21% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/color_utils.lua 9% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 22% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 82a9dc54babb46e7e6878a3b77610dbb6c12b6bd

github-actions[bot] avatar Jul 22 '24 19:07 github-actions[bot]

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] avatar Aug 06 '24 19:08 github-actions[bot]