soapui icon indicating copy to clipboard operation
soapui copied to clipboard

Bugfix so authorizationcode flow is supported.

Open kriebb opened this issue 3 years ago • 0 comments

  • Used inheritance to minimize code changes, Liskuv subsitution is used here

  • Created a new component, so working open/closed principle is used. Other browsers and flows are not impacted

  • Added logging, so you see to what location you are directed and if you get an error from the IDP, you can see it.

  • Added some @Override tags, so methods could be overwritten.

  • Made a public final static DEFAULT_ERROR_PAGE private and made a getDefaultErrorPage, so an other default error page can be made with somewhat more specific information ( but honostly, after adding the soapui log, this is not needed)

  • No support yet for authrizationcode +pkce, because my java is not what it should be. :) But good enough to suggest this fix.

  • No tests created, it is only a new userinterface browsercomponent that was changed. Did test it manually with auth0.com

  • Linked issue:

https://github.com/SmartBear/soapui/issues/754

kriebb avatar Oct 31 '22 14:10 kriebb