Update to 1.21

[WalshyDev]

Description

Updates to 1.21 - big shout out to MockBukkit team and @Intybyte for the work on tests

Proposed changes

Updated Slimefun code to support 1.21

Related Issues (if applicable)

N/A

Checklist

• [ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
• [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
• [ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
• [ ] I followed the existing code standards and didn't mess up the formatting.
• [ ] I did my best to add documentation to any public classes or methods I added.
• [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
• [ ] I added sufficient Unit Tests to cover my code.

[github-actions[bot]]

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention	Label
feature/**	🎈 Feature
fix/**	✨ Fix
chore/**	🧹 Chores
api/**	🔧 API
performance/**	💡 Performance Optimization
compatibility/**	🤝 Compatibility

---

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

[github-actions[bot]]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: e7d9232e

https://preview-builds.walshy.dev/download/Slimefun/4248/e7d9232e

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

[WalshyDev]

This still needs major testing

[Boomer-1]

testing produced multiple errors immediately which stopped any further testing. I've linked them from the contributors channel on discord. https://discord.com/channels/565557184348422174/565570276038017044/1290525215461216266

[sonarqubecloud[bot]]

Quality Gate passed

Issues
30 New issues
0 Accepted issues

Measures
0 Security Hotspots
34.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[LauncherMeta]

testing produced multiple errors immediately which stopped any further testing. I've linked them from the contributors channel on discord. https://discord.com/channels/565557184348422174/565570276038017044/1290525215461216266

Is there 1.21 build available? where? ty mate

[Boomer-1]

testing produced multiple errors immediately which stopped any further testing. I've linked them from the contributors channel on discord. https://discord.com/channels/565557184348422174/565570276038017044/1290525215461216266

Is there 1.21 build available? where? ty mate

no. this is the work being done to get 1.21 up and running.

[sruly09]

when will 1.21 version come out?

[Intybyte]

[Boomer-1]

when all the changes that mojang and paper put in place are addressed and fixed. feel free to help

[Boomer-1]

lets try to keep comments not related to the PR on Discord please

[Outfit8TSB]

Github Issue PR4248-1

I Got an Unexpected Exception when i ran /sf cheat on my own plazma fork.

[07:32:38 WARN]: [Slimefun] Task #32778 for Slimefun v4.9-UNOFFICIAL generated an exception
java.lang.ClassCastException: Cannot cast io.github.thebusybiscuit.slimefun4.api.items.SlimefunItemStack to org.bukkit.craftbukkit.inventory.CraftItemStack
at java.base/java.lang.Class.cast(Class.java:4067) ~[?:?]
at org.bukkit.craftbukkit.inventory.CraftItemStack.getCraftStack(CraftItemStack.java:46) ~[sangsang-1.21.1.jar:1.21.1-DEV-7120601]
at org.bukkit.craftbukkit.inventory.CraftItemStack.asNMSCopy(CraftItemStack.java:97) ~[sangsang-1.21.1.jar:1.21.1-DEV-7120601]
at org.bukkit.craftbukkit.inventory.CraftInventory.setItem(CraftInventory.java:100) ~[sangsang-1.21.1.jar:1.21.1-DEV-7120601]
at Slimefun v4.9-UNOFFICIAL.jar/me.mrCookieSlime.CSCoreLibPlugin.general.Inventory.ChestMenu.setup(ChestMenu.java:228) ~[Slimefun v4.9-UNOFFICIAL.jar:?]
at Slimefun v4.9-UNOFFICIAL.jar/me.mrCookieSlime.CSCoreLibPlugin.general.Inventory.ChestMenu.open(ChestMenu.java:262) ~[Slimefun v4.9-UNOFFICIAL.jar:?]
at Slimefun v4.9-UNOFFICIAL.jar/io.github.thebusybiscuit.slimefun4.implementation.guide.SurvivalSlimefunGuide.openMainMenu(SurvivalSlimefunGuide.java:188) ~[Slimefun v4.9-UNOFFICIAL.jar:?]
at Slimefun v4.9-UNOFFICIAL.jar/io.github.thebusybiscuit.slimefun4.core.guide.SlimefunGuide.openMainMenu(SlimefunGuide.java:81) ~[Slimefun v4.9-UNOFFICIAL.jar:?]
at Slimefun v4.9-UNOFFICIAL.jar/io.github.thebusybiscuit.slimefun4.core.guide.SlimefunGuide.lambda$openMainMenuAsync$0(SlimefunGuide.java:74) ~[Slimefun v4.9-UNOFFICIAL.jar:?]
at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:86) ~[sangsang-1.21.1.jar:1.21.1-DEV-7120601]
at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:475) ~[sangsang-1.21.1.jar:1.21.1-DEV-7120601]
at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1779) ~[sangsang-1.21.1.jar:1.21.1-DEV-7120601]
at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:517) ~[sangsang-1.21.1.jar:1.21.1-DEV-7120601]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1651) ~[sangsang-1.21.1.jar:1.21.1-DEV-7120601]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1348) ~[sangsang-1.21.1.jar:1.21.1-DEV-7120601]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:338) ~[sangsang-1.21.1.jar:1.21.1-DEV-7120601]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

it may happened at papermc side.

[Intybyte]

Please stop posting anything here, we already know what we need to fix it just requires time and patience and lots of changes, also you will not recive support for your own fork of the plugin.

[JustinDevB]

Do we ever plan on updating this? Or are we just going to let minecraft continue to update and abandon this project

[ybw0014]

@JustinDevB Please do not add noisy comments to this PR, thank you. Questions go on Discord only.

[JustinDevB]

@JustinDevB Please do not add noisy comments to this PR, thank you. Questions go on Discord only.

All that happens there is people get warned or muted for asking about the progress. Seems to be a topic nobody is allowed to discuss anywhere.

[Lamby777]

All that happens there is people get warned or muted for asking about the progress. Seems to be a topic nobody is allowed to discuss anywhere.

can confirm, i was banned for no reason (i don't even talk there)

[Outfit8TSB]

Please stop posting anything here, we already know what we need to fix it just requires time and patience and lots of changes, also you will not recive support for your own fork of the plugin.

Look, it's not fork(and it's git clone) and it's resolved by #4253. Ok? I marked it as resolved for you.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
256 New issues
0 Accepted issues

Measures
0 Security Hotspots
46.4% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarCloud

[asmolfemboi]

You're leaving an entire bubble out in the rain, you can keep talking about it, but slimefun will soon die for all the servers that once offered it!

[Boomer-1]

You're leaving an entire bubble out in the rain, you can keep talking about it, but slimefun will soon die for all the servers that once offered it!

please leave unproductive comments like these out of the PR discussion. since you clearly didn't look at what's going on and seen the progress, you aren't helping anyone.

[sruly09]

yay the checklist is shrinking

[logicaleman314]

Wondering what still needs to be done, Both this and the itemstack rewrite have been waiting to merge for almost a month now. Is there another issue that is being worked on?

[Outfit8TSB]

i made a conflict resolution Branch. Check #4292.

[DejVIIK-Original]

Hello Approximately when will it be out? Release date to 1.21.x

[Rafasxa]

Hello Approximately when will it be out? Release date to 1.21.x

It will probably take a long time; it seems like they have abandoned the Slimefun project.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
335 New issues
0 Accepted issues

Measures
0 Security Hotspots
46.4% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud

[DejVIIK-Original]

Thanks for Experimental version for Minecraft 1.21

[LordDarce]

Shame this is abandonware now, used to be a solid plugin All the devs are interested in doing is whining at their fanbase in Discord

[ybw0014]

Shame this is abandonware now, used to be a solid plugin All the devs are interested in doing is whining at their fanbase in Discord

@LordDarce Please don't spread misinformation. Slimefun is an open-source project maintained by community devs in their free time. Plus, this PR was merged 2 weeks ago, calling it "abandoned" makes no sense at all. For the second point, if you have proof of devs "whining" at the fanbase, share it. Otherwise, your statement is baseless and misleading.

[LordDarce]

Shame this is abandonware now, used to be a solid plugin All the devs are interested in doing is whining at their fanbase in Discord

@LordDarce Please don't spread misinformation. Slimefun is an open-source project maintained by community devs in their free time. Plus, this PR was merged 2 weeks ago, calling it "abandoned" makes no sense at all. For the second point, if you have proof of devs "whining" at the fanbase, share it. Otherwise, your statement is baseless and misleading.

I'm not documenting the Devs abysmal behavior for you, chief. You can do your own research if you're so upset