Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Undeprecate the CS-Core stuff for now

Open Seggan opened this issue 1 year ago • 3 comments

Description

Undepreated the old stuff in me.mrCookieSlime. This was done because we have no replacement yet, and the IDE warnings are getting annoying in addons. Deprecate these after having a replacement.

Checklist

  • [ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [ ] I added sufficient Unit Tests to cover my code.

Seggan avatar May 07 '24 19:05 Seggan

Your Pull Request was automatically labelled as: "🔧 API" Thank you for contributing to this project! ❤️

github-actions[bot] avatar May 07 '24 19:05 github-actions[bot]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 5c1e617f

https://preview-builds.walshy.dev/download/Slimefun/4187/5c1e617f

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar May 07 '24 19:05 github-actions[bot]

I’ve not had a chance to actually review the code changes (which I’m sure are sound) but I am all-for this change. 100% support this ha!

Sefiraat avatar May 08 '24 19:05 Sefiraat