Storm Staff PVP overhaul to improve accessibility

[Alessio-Colombo]

Description

This PR is twofold: on one hand, it transforms all the damage dealt by lightnings to damage dealt by the caster; on the other, it adds the ability to enable StormStaff usage in non PVP areas (as any damage is now automatically nullified, having the EntityDamageByEntityEvent been "transformed" to attribute the damage to the caster).

Proposed changes

• Substituted any EntityDamageByEntityEvent caused by StormStaff lightnings with ones with the caster as damager
• Added an ItemSetting to allow enabling usage of Storm Staves in non PVP area (damage to players is prevented)

Related Issues (if applicable)

#3396 #3408

Checklist

• [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
• [x] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
• [x] I followed the existing code standards and didn't mess up the formatting.
• [x] I did my best to add documentation to any public classes or methods I added.
• [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
• [ ] I added sufficient Unit Tests to cover my code.

[github-actions[bot]]

Your Pull Request was automatically labelled as: "🎈 Feature" Thank you for contributing to this project! ❤️

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

9.1% Coverage
0.0% Duplication

[Alessio-Colombo]

Welp before I change it, I'd like to hear what @TheBusyBiscuit thinks since he assigned himself too. If he agrees sure, otherwise I'd rather have the conversation and decision happen without moving stuff back and forth

[TheBusyBiscuit]

It's been over a year, closing this as stale.