Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Soulbound not disabled when disabled in config

Open winnipeg21 opened this issue 4 years ago โ€ข 4 comments

โ— Checklist

  • [x] I am using the official english version of Slimefun and did not modify the jar.
  • [X] I am using an up to date "DEV" (not "RC") version of Slimefun.
  • [X] I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • [X] I searched for similar open issues and could not find an existing bug report on this.

๐Ÿ“ Description

When I disabled soulbound items in the config already soulbound enchanted items from the ancient rune still functioned. No other config option exists for disabling already soulbound enchanted items.

๐Ÿ“‘ Reproduction Steps

  1. Have ancient rune of soulbind enabled
  2. Drop the rune with a piece of armor to enchant it
  3. Disable the rune
  4. Use the soulbound item

๐Ÿ’ก Expected Behavior

Expected behaviour would be the soulbounded item would not function just like any SF item that is disabled.

๐Ÿ“ท Screenshots / Videos

https://discord.com/channels/565557184348422174/565569972697301020/914758306130706442 <-- Related convo in the SF discord

๐Ÿ“œ Server Log

Nothing in Logs

๐Ÿ“‚ /error-reports/ folder

No errors

๐Ÿ’ป Server Software

Purpur

๐ŸŽฎ Minecraft Version

1.17.x

โญ Slimefun version

Versions

๐Ÿงญ Other plugins

No response

winnipeg21 avatar Nov 29 '21 19:11 winnipeg21

Tested it, still works

FN-FAL113 avatar Feb 01 '22 06:02 FN-FAL113

I thought I already replied to this one...

The soulbound listener still works even the item is disabled so this is why it is happening.

variananora avatar Feb 01 '22 06:02 variananora

It's a hit or miss bug Imo it is a bug. So disabling the rune should disable the enchant but it doesn't since the listener is still active.

One of two things needs to happen:

Disable soundbound rune would disable the listener

Add an option to toggle the listener

winnipeg21 avatar Feb 01 '22 06:02 winnipeg21

I thought I already replied to this one...

The soulbound listener still works even the item is disabled so this is why it is happening.

Lol we messaged at the same time. You did in discord and I brought it to bug reports back in November as phoenix suggested along with me. You suggested to add it under suggested which I believe I also did

winnipeg21 avatar Feb 01 '22 06:02 winnipeg21