Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Disabling some Slimefun items shifted some multiblocks recipe

Open variananora opened this issue 4 years ago • 0 comments

❗ Checklist

  • [X] I am using the official english version of Slimefun and did not modify the jar.
  • [X] I am using an up to date "DEV" (not "RC") version of Slimefun.
  • [X] I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • [X] I searched for similar open issues and could not find an existing bug report on this.

📍 Description

In this case I'll disable Stone Chunks from items.yml and try using Compressor

This also happened here: https://github.com/TheBusyBiscuit/ExoticGarden/issues/210

I think this is because when registering recipe it didn't check for the disabled items.

https://github.com/Slimefun/Slimefun4/blob/fc207b6a83866cca138e4a0b43d02e1e55a5c3b0/src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/multiblocks/Compressor.java#L37-L47

I haven't tried anything else but looking at things I think I can make this work one Ore Grinder and Ore Crusher too..

📑 Reproduction Steps

  1. Install Slimefun
  2. Disable Stone Chunks from items.yml
  3. Look at the guide, the recipe just got shifted
  4. Try using the compressor just using 1 coal
  5. It will output 8 coal

💡 Expected Behavior

The recipe should not be shifted.

📷 Screenshots / Videos

https://youtu.be/sgOPYilkLis

Side by side

Untitled

Normal Recipe

image

Shifted Recipe

image

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.17.x

⭐ Slimefun version

> sf versions
[10:34:39 INFO]: This Server uses the following setup of Slimefun:
Paper git-Paper-279 (MC: 1.17.1)
Slimefun DEV - 974 (git 36c6d154)
Metrics-Module #28
Java 16

No Addons installed

🧭 Other plugins

No response

variananora avatar Sep 26 '21 03:09 variananora