SensibleToolbox icon indicating copy to clipboard operation
SensibleToolbox copied to clipboard

Fixed removing EChests from Tuner and Tuner opening in other GUIs

Open Sefiraat opened this issue 4 years ago • 1 comments

Description

Placed Ender Boxes can be pulled out from the tuner GUI without any effort. Found while testing this issue, the Ender Tiner will overide interactions in other GUI's (like /sf open_guide)

Changes

Fixed the return when tuningblock != null in EnderTuner#onShiftClickExtract. Wrapped onInteractEvent with an action check.

Related Issues

N/A

Checklist

  • [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [ ] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

Sefiraat avatar Jul 05 '21 17:07 Sefiraat

Dupe: https://user-images.githubusercontent.com/20646323/124656477-2b22de00-de99-11eb-91c0-852a76d891e7.mp4

Ender Tuner Hijacking GUIs https://user-images.githubusercontent.com/20646323/124656555-44c42580-de99-11eb-9988-b9d44a242585.mp4

Edit : Weird 4k clipping fixed

Sefiraat avatar Jul 06 '21 19:07 Sefiraat