SensibleToolbox icon indicating copy to clipboard operation
SensibleToolbox copied to clipboard

Fix Recipe book dupe(s) and Block break dupes

Open Sefiraat opened this issue 4 years ago • 0 comments

Description

STB Recipe books will allow users to remove items if opened twice fast enough (autoclicker makes this trivial) allowing for the removal of any STB/Vanilla/other registered recipe item assuming they are on the correct page before attempting. STB machines allow their items to be removed if the machine is broken while being viewed either by TNT or a 2nd player.

Changes

For recipe book dupes, I added a check to see if the player has the inventory opened before allowing the 2nd instance to open. This resolved the dupe and has no noticable side effects on machine GUIs. For the machines I added a check for viewing players and kick them out.

Related Issues

Don't think these have ever been reported weirdly!

Checklist

  • [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [ ] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

Sefiraat avatar Jul 05 '21 16:07 Sefiraat