SlicerExecutionModel icon indicating copy to clipboard operation
SlicerExecutionModel copied to clipboard
verified publisher icon Slicer

Installation of SlicerExecutionModel

Open fbudin69500 opened this issue 10 years ago • 13 comments

When running the install step of SlicerExecutionModel, only one file is installed: <CMAKE_INSTALL_PREFIX>/lib/ModuleDescriptionParser/libModuleDescriptionParser.a It is therefore not possible to install SlicerExecutionModel and use it. It would be great to have a real install step that would install all the necessary files to be able to actually install SlicerExecutionModel.

fbudin69500 avatar Jul 24 '15 18:07 fbudin69500

:+1:

Here are the steps:

  • [ ] Add missing install rules and properly specify components
  • [ ] Update SlicerExecutionModelConfig.cmake so that it can work from either the build or install tree
    • documentation: https://cmake.org/cmake/help/v3.5/manual/cmake-packages.7.html#creating-packages
    • example 1: https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/blob/7381d004886d6ed5f21c561fc8c1a9a2e376b7bb/CMakeLists.txt#L372-L417
    • example 2: https://github.com/commontk/DCMTK/blob/545de8711c76c9d51c1509b83e6714635a899a10/CMake/GenerateCMakeExports.cmake

jcfr avatar Jul 24 '15 18:07 jcfr

:+1:

@naucoin can you please work on resolving this issue, as part of the QIICR activities?

fedorov avatar Mar 10 '16 19:03 fedorov

@naucoin To help you in the process, I updated https://github.com/Slicer/SlicerExecutionModel/issues/44#issuecomment-124608240 with some references. Do not hesitate to ask if you have any questions.

jcfr avatar Mar 10 '16 19:03 jcfr

@fedorov @jcfr I'll look into it, can you assign the issue to me?

naucoin avatar Mar 10 '16 19:03 naucoin

By April 5 @naucoin will provide time estimate for completing this task

fedorov avatar Mar 31 '16 19:03 fedorov

@fedorov Starting work on it today, should be done by early next week.

naucoin avatar Apr 05 '16 18:04 naucoin

:+1:

jcfr avatar Apr 05 '16 18:04 jcfr

@jcfr I'd found the documentation on making cmake packages before, but it jumps right into the complexities. Do you know of any examples that use a simpler set up, or a uses step by step approach as a how to rather than jumping right into a complex cmake file? I'm working my way through it but could use a better tutorial.

naucoin avatar Apr 06 '16 18:04 naucoin

Based on the discussion with Nicole today, this task turned out to be much more difficult than initially estimated. We need to address immediate deadlines on other projects, so I asked Nicole to lower the priority of this issue. Resolving this issue is not a stopper for us, since it is sufficient to package the build directory, or to just build the repository, since it is relatively small.

fedorov avatar Apr 14 '16 20:04 fedorov

This issue is a showstopper for its dependent projects to be installable and packageable.

yurivict avatar Dec 12 '18 22:12 yurivict

@yurivict It would make sense to move forward and support installation of this project. If that is an option for your organization, you could look into getting a support product here. I would be happy to discuss option and can be reached at jcfr [at] kitware [dot] com

jcfr avatar Dec 14 '18 18:12 jcfr

Ok, just add installation instructions then.

yurivict avatar Dec 14 '18 18:12 yurivict

To clarify, it requires more than simply adding instructions. Supporting installation of SlicerExecutionModel so that CLIs can be built using it still requires some work (the idea is to finalize this pull request https://github.com/Slicer/SlicerExecutionModel/pull/61).

jcfr avatar Dec 14 '18 18:12 jcfr