NeoGPS icon indicating copy to clipboard operation
NeoGPS copied to clipboard

TimeLib defines DAYS_PER_WEEK as type time_t with a value of 7. TimeL…

Open richteel opened this issue 4 years ago • 0 comments

…ib's time_t is defined as unsigned long with a value of 7. This is compatable with NeoGPS declaration of DAYS_PER_WEEK with type uint8_t if cast to uint8_t. I modified the code to check if DAYS_PER_WEEK is defined and cast DAYS_PER_WEEK as uint8_t when used.

This is an alternate way to resolve the conflict between NeoGPS and TimeLib. User, tscofield, proposed a similar fix by renaming DAYS_PER_WEEK but I believe this may be a slightly better resolution to the issue.

See issues

BTW: I looked into applying a similar fix to TimeLib but the issue only seemed to be resolved when applied to NeoGPS.

richteel avatar Sep 15 '21 10:09 richteel