SkyblockerMod
Editor Config
Personally, I prefer spaces over tabs. Spaces provide a uniform appearance, regardless of the system or editor used. Tabs can be displayed differently depending on the system or individual settings. Therefore, spaces are the more reliable choice for consistent code that looks the same everywhere.
In intellij there is a setting that converts tabs to 4 spaces, which is the best compromise.
I put changes requested because we have decided on an import order and this PR hasn't been updated with it yet
I still hold that this pr is pretty unnecessary without indent_style, so I think I will leave this as is until a decision is reached on that. However, I can and will remove the 3 import related entries.
I still hold that this pr is pretty unnecessary without
indent_style, so I think I will leave this as is until a decision is reached on that. However, I can and will remove the 3 import related entries.
I was saying that me and LIAP agreed on an import order in the dev chat but this hasn't been updated with it yet
I was saying that me and LIAP agreed on an import order in the dev chat but this hasn't been updated with it yet
Most files currently have the import layout in this pr, and I don't see a point changing that.
I was saying that me and LIAP agreed on an import order in the dev chat but this hasn't been updated with it yet
Most files currently have the import layout in this pr, and I don't see a point changing that.
We aren't retroactively applying this so it doesn't matter and the "default" is way too messy
Maybe you missed it but I had sent you a thing on discord about imports, also idk if its possible but it might also be nice to enforce the usage of @Override for overridden methods
I don't really agree with that import, so I'm leaving it out for now. After searching a bit I don't see a way to enforce override annotation, you'll have to manually enable the inspection on intellij.
I don't really agree with that import, so I'm leaving it out for now. After searching a bit I don't see a way to enforce override annotation, you'll have to manually enable the inspection on intellij.
With the upcoming usage of ASM for class init import conflicts should hopefully be less common so maybe its not needed now