SkyCrypt icon indicating copy to clipboard operation
SkyCrypt copied to clipboard

If all of a user's profiles are deleted, it is no longer able to be unfavorited

Open Rayset8 opened this issue 4 years ago • 7 comments

Describe the bug I favourited a profile before it got banned. Its coop members then coopkicked it, leaving it with no profiles left. Clicking that profile on the homepage will try to open that profile, however it responds with "Player has no SkyBlock profiles.", making it impossible to un-favourite it and basically restricts the max favourites by 1.

Profile/Location https://sky.shiiyu.moe/stats/owobf/Watermelon

Expected behavior Clicking on the star on the lower right corner of the profile would un-favourite it.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 91.0.4472.77

Rayset8 avatar May 29 '21 12:05 Rayset8

Thank you for bringing this issue to our attention. Expect a developer to comment within the first 2-3 days of issue submission

github-actions[bot] avatar May 29 '21 12:05 github-actions[bot]

Clicking on the star on the lower right corner of the profile would un-favourite it.

I like this idea

nstringham avatar May 29 '21 20:05 nstringham

@Rayset8 this is a problem that needs to be fixed but for now you can clear cookies to remove all your favorites if you need the 5th slot back.

nstringham avatar May 29 '21 20:05 nstringham

another solution would be to add some logic to automatically remove invalid favorites

nstringham avatar May 29 '21 20:05 nstringham

we could also add a section to the settings menu that would allow users to manage their favorites since there is currently no good way to reorder favorites

nstringham avatar May 29 '21 20:05 nstringham

Favorites are based on uuid so an alternative method would just be to create a new profile on that account but I suppose that would not work in this situation given that the user was banned.

metalcupcake5 avatar May 29 '21 21:05 metalcupcake5

Favorites are based on uuid so an alternative method would just be to create a new profile on that account but I suppose that would not work in this situation given that the user was banned.

The main problem with this is that it would require the cooperation of the account owner which is not necessarily the same as the user that favored them

nstringham avatar May 29 '21 22:05 nstringham