SkyCrypt icon indicating copy to clipboard operation
SkyCrypt copied to clipboard

Tecture Pack inconsistency

Open kada49 opened this issue 1 year ago • 5 comments

Describe the bug Rift collections have custom tp icons even with just vanilla tp enabled.

Profile/Location https://sky.shiiyu.moe/stats/kada49/Raspberry#Collections

Expected behavior SHow player heads like in the boss collections in the category below.

Screenshots Screenshot from 2024-03-03 20-39-47 WhatsApp Image 2024-03-03 at 20 49 14

Desktop (please complete the following information):

  • OS: Fedora 39 on Linux 6.7.6
  • Browser: Mozilla Firefox
  • Version 123.0

Smartphone (please complete the following information):

  • Device: Samsung Galaxy A52 4G (SM-A525F)
  • OS: Android 13, One UI 5.1
  • Browser: Samsung Internet
  • Version: 24.0.3.4

kada49 avatar Mar 03 '24 19:03 kada49

This looks like your first issue on SkyCrypt! Thank you for bringing this issue to our attention. Expect a developer to comment within the first 3-5 business days of issue submission.

github-actions[bot] avatar Mar 03 '24 19:03 github-actions[bot]

I can confirm that this issue also occurs on desktop. The issue is also present for the Magmafish, Chili Pepper, Sulphur, Hard Stone and Gemstone collections. I will look further into this issue to see if I can solve it.

DespicableGoose avatar Mar 10 '24 22:03 DespicableGoose

I also found that the mithril collection has the same issue

kada49 avatar Mar 12 '24 08:03 kada49

I have just identified the source of the issue. The issue stems from the file following file: src/scripts/update-collections.js, more specifically on line 22. This code automatically takes the ID of item (from API), and adds that as the texture of the item. I'll see if I can fix this behavior at a later time, unless you or someone else is willing to resolve this issue soon.

DespicableGoose avatar Mar 28 '24 05:03 DespicableGoose

Turns out, I have no idea how to test changes with texture packs (when I launch development servers it has no working textures), so I can't really help with this, at least not with the knowledge I have right now.

DespicableGoose avatar Apr 12 '24 03:04 DespicableGoose