Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Item Comparison bug

Open Asleeepp opened this issue 1 year ago • 7 comments

Skript/Server Version

[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript] Server Version: 1.20.6-2233-0d6766e (MC: 1.20.6)
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript] Skript Version: 2.9.0-pre1 (skriptlang-github)
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript] Installed Skript Addons: 
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript]  - skript-placeholders v1.6.0 (https://github.com/APickledWalrus/skript-placeholders)
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript]  - SkCord v2.2-RELEASE
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript]  - skript-particle v1.3.1 (https://github.com/sovdeeth/skript-particle)
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript]  - skript-reflect v2.4 (https://github.com/SkriptLang/skript-reflect)
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript]  - SkBee v3.5.6 (https://github.com/ShaneBeee/SkBee)
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript] Installed dependencies: 
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript]  - Vault v1.7.3-b131
[16:39:18] [Render thread/INFO]: [System] [CHAT] [Skript]  - WorldGuard v7.0.10+d9424b1

Bug Description

I made this check if 1 of player's tool is netherite sword named "&dSword" it works fine, however, when the item in question loses durability, the check no longer parses

Expected Behavior

it probably shouldn't care about durability

Steps to Reproduce

1, make a skript with this

on click:
    if 1 of player's tool is netherite sword named "&dSword":
        # do something

2, test with item, first with no durability loss, then with 3, profit

Errors or Screenshots

No response

Other

No response

Agreement

  • [X] I have read the guidelines above and affirm I am following them with this report.

Asleeepp avatar Jul 11 '24 19:07 Asleeepp

Yeah, I encountered the same issue. Skript 2.9 full release

myavuzokumus avatar Jul 17 '24 18:07 myavuzokumus

introduced at or prior to 2.8.0

sovdeeth avatar Jul 18 '24 06:07 sovdeeth

Do you have any ETA for fixing it? Isn't it a critical bug? I am continuously looking to the Nightly versions but I guess there isn't any update yet.

myavuzokumus avatar Jul 25 '24 21:07 myavuzokumus

Do you have any ETA for fixing it? Isn't it a critical bug? I am continuously looking to the Nightly versions but I guess there isn't any update yet.

iirc Sovde is working on a new system for comparisons, you might just need to wait until thats finished

Asleeepp avatar Jul 25 '24 21:07 Asleeepp

It is not critical as you can achieve the results you want by checking properties individually:

if:
    type of {_item} is netherite sword
    name of {_item} is "&dSword"
then:
    do something

sovdeeth avatar Jul 25 '24 21:07 sovdeeth

Yes, you are right but it's mean I need to change whole codes about it :D

myavuzokumus avatar Jul 25 '24 22:07 myavuzokumus

Is there any progress?

myavuzokumus avatar Aug 27 '24 09:08 myavuzokumus