Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Enhancement to 'Can See' condition

Open MissingReports opened this issue 1 year ago • 3 comments

Suggestion

The 'Can See' condition only accepts Player and Player where in Spigot it accepts Player and Entity

New Syntax:

%players% (is|are) [(in)]visible for %entities% 
%players% can see %entities% 
%players% (is|are)(n't| not) [(in)]visible for %entities% 
%players% can('t| not) see %entities%

Why?

The more stuff you can do with a condition, the better

Other

No response

Agreement

  • [X] I have read the guidelines above and affirm I am following them with this suggestion.

MissingReports avatar Jun 17 '24 06:06 MissingReports

I think you misunderstood. The method is Player#canSee(Entity / Player), so it's for checking if a Player can see an Entity or another Player. This is what the condition already does. It doesn't support entity sees entity, because that would need an Entity#canSee(Entity) method.

sovdeeth avatar Jun 17 '24 06:06 sovdeeth

I don't mean entity sees entity, i mean player sees entity

the current syntax allows player sees player only

MissingReports avatar Jun 17 '24 06:06 MissingReports

Oh my apologies, I mistook your "new syntax" for the current syntax!

sovdeeth avatar Jun 17 '24 06:06 sovdeeth