Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Attempt to estimate world in teleport when it's not specified.

Open Moderocky opened this issue 2 years ago • 0 comments

Description

I previously tried to fix this issue in the Entity utils teleport method, by estimating their target world from their source world if it wasn't specified.

Unfortunately, EffTeleport does a lot of stuff that isn't teleporting (like setting the move event target, loading the chunk), so the last patch didn't fix that.

This time I do my best to estimate a location in all cases if I can, or just return if I can't. It's not ideal, but it's the best we can do to avoid an error while not just failing silently with no feedback for the user about why their teleport did nothing.

Are there any more of these?

Probably, but the only way to find them would be to check every single usage of Location across all 500 and so files, and it's very hit-or-miss whether Bukkit requires a location or not.


Target Minecraft Versions: any Requirements: none Related Issues: fixes #6610

Moderocky avatar Apr 26 '24 12:04 Moderocky