Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Change comment parsing

Open sovdeeth opened this issue 1 year ago • 2 comments

Description

This PR allows the usage of un-escaped #s in quoted strings:

  1. You do not have to double # in strings anymore. All # in text will appear as-is in the parsed code. This means the following is valid: set {_a} to "#1: <#abcdef>test" # test

I also allowed both <##abcdef> and <#abcdef> to be valid hex colours to minimize breaking changes for users.

This was also a good chance to update all the tests to remove the # 1, # 2, etc now that the tests include line numbers.

NOTE: strings that are not quoted, like the description entry in command structure, or the command pattern itself, still require escaped strings. Only explicitly quoted strings will not need doubled #s.


Target Minecraft Versions: any Requirements: none Related Issues: #5181

sovdeeth avatar Apr 18 '24 21:04 sovdeeth

Issues found with entries and commands, please hold off on reviews

sovdeeth avatar Apr 19 '24 10:04 sovdeeth

Just marking this so that I remember to review it soon

one day my prince will come

sovdeeth avatar Jun 11 '24 17:06 sovdeeth