Skript icon indicating copy to clipboard operation
Skript copied to clipboard

🚀 Add equip items

Open AyhamAl-Ali opened this issue 2 years ago • 5 comments

Description

Added equipping (aka giving) items not just armor. To be able to add this I had to add a new syntax to the first pattern [hat:as [a] (hat|helmet|cap)] in order to allow users to equip items as hats since that was the default behavior before this which means this PR has a breaking change, BUT syntax may not be the best so feel free to suggest improvements.


Target Minecraft Versions: any Requirements: none Related Issues: none

  • #6322

AyhamAl-Ali avatar Jan 21 '24 22:01 AyhamAl-Ali

Breaking change, but it's very rare someone actually uses equip for helmet setting.

TheLimeGlass avatar Jan 25 '24 20:01 TheLimeGlass

Breaking change, but it's very rare someone actually uses equip for helmet setting.

Indeed it's a breaking change I forgot to add the label

AyhamAl-Ali avatar Jan 25 '24 20:01 AyhamAl-Ali

Tests? 🥺        👉 👈

How to test on players? 🥺

AyhamAl-Ali avatar Apr 07 '24 13:04 AyhamAl-Ali

Tests? 🥺        👉 👈

How to test on players? 🥺

well you don't need to, but i'm sure pikachu has some tips for that. I was thinking with a zombie or pig or something.

sovdeeth avatar Apr 07 '24 13:04 sovdeeth

Tests? 🥺        👉 👈

How to test on players? 🥺

well you don't need to, but i'm sure pikachu has some tips for that. I was thinking with a zombie or pig or something.

@Pikachu920 🫣 mayday mayday mayday! I will add tests for other entities as well

AyhamAl-Ali avatar Apr 07 '24 13:04 AyhamAl-Ali