Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Add inventory size to the slots syntax

Open TheLimeGlass opened this issue 2 years ago • 2 comments

Description

Add inventory size of %inventories% to the slots syntax. Many people don't know inventory size actually exists in Skript. Addons call this term "inventory size", so this pull adds an aliases for it.


Target Minecraft Versions: any Requirements: none Related Issues: none

TheLimeGlass avatar Dec 18 '23 05:12 TheLimeGlass

I personally find the usage of "inventory size" confusing and don't believe this should be something encouraged to use. For me when I see "inventory size" this feels more related to "rows" and not "slots" oh the inventory size of a barrel is 3 makes sense but reading it as inventory size of a barrel is 27 that's much less understanding as we're not talking about a size of the inventory to me.

And lastly is there any way to possible make the syntax look like less of a mess? (holder[s]|viewers|[amount of] rows|([amount of] slots|inventory size)) of %inventories%

This issue is too prevalent on skript expressions where there's multiple options and should be changed to make reading docs easier and more understandable.

Fusezion avatar Dec 18 '23 05:12 Fusezion

And lastly is there any way to possible make the syntax look like less of a mess? (holder[s]|viewers|[amount of] rows|([amount of] slots|inventory size)) of %inventories%

This issue is too prevalent on skript expressions where there's multiple options and should be changed to make reading docs easier and more understandable.

I agree, these should each be different patterns.

sovdeeth avatar Mar 21 '24 17:03 sovdeeth