Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Enhance the scheduling system API for future additions

Open TheLimeGlass opened this issue 2 years ago • 7 comments

Description

Updates the entire Task scheduling system in Skript. This API change is required to support versioning reflection of future additions like Folia https://github.com/PaperMC/Folia

I have a branch which enables Folia support for Skript and completes the Task scheduling system to adapt to Folia properly https://github.com/SkriptLang/Skript/tree/feature/folia Do note this is in experimental phase and still throws exceptions due to the following;

The main changes that are needed to that branch is replacing Bukkit.getScheduler with Skript's new Task luckily old parts of Skript accomplish this, but ever since bensku additions, the Skript project has had the habit of using Bukkit.getScheduler directly, rather than Skript's own Task. So many parts of Skript are going to need changes in that branch.

Once this is merged, i'll directly work on the Folia branch for the FoliaScheduler class.


Target Minecraft Versions: none Requirements: none Related Issues: https://github.com/SkriptLang/Skript/issues/5645

TheLimeGlass avatar Aug 31 '23 22:08 TheLimeGlass

Placing under draft until I get opinions from the Core SkriptLang team and I also have all the JavaDocs to do.

TheLimeGlass avatar Aug 31 '23 22:08 TheLimeGlass

Not core team, but Folia support would definitely be nice and fits the goals of Skript :)

Would it be possible to convert all usages of BukkitScheduler to Skript's Task on the main branch and then rebase the folia branch? We probably should've stuck to Skript's Task anyway...

bluelhf avatar Sep 01 '23 07:09 bluelhf

Closing due to inactivity.

sovdeeth avatar Jul 16 '24 06:07 sovdeeth

This is a very important future change requiring attention.

TheLimeGlass avatar Jul 16 '24 21:07 TheLimeGlass

This is a very important future change requiring attention.

There are requested changes still waiting from September 2023. These haven't been addressed since, hence closed for inactivity. Do you intend to address these requests?

sovdeeth avatar Jul 16 '24 21:07 sovdeeth

I would like this.

KittenPixel avatar Aug 13 '24 02:08 KittenPixel

I didn't realize how well I engineered this API. I had to re-understand all of what was being done.

TheLimeGlass avatar Aug 31 '24 16:08 TheLimeGlass

Inactive

sovdeeth avatar May 06 '25 21:05 sovdeeth