Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Enhancement/permission changer

Open TheLimeGlass opened this issue 3 years ago • 4 comments

Description

Adds remove/add to permissions

TheLimeGlass avatar Jul 26 '22 06:07 TheLimeGlass

I like the addition and the code looks good, but I'm concerned about the changes to permissions being temporary. Is there a way we can make them permanent without a ton of effort? I think users will get confused and wonder why the changes aren't lasting over restarts, no matter how much documentation we have, and with something as critical as permissions, I'm not sure that's something we should just accept.

sovdeeth avatar Mar 19 '24 16:03 sovdeeth

I like the addition and the code looks good, but I'm concerned about the changes to permissions being temporary. Is there a way we can make them permanent without a ton of effort? I think users will get confused and wonder why the changes aren't lasting over restarts, no matter how much documentation we have, and with something as critical as permissions, I'm not sure that's something we should just accept.

No. The whole purpose of permission plugins is to allow for database saving. Bukkit does not have a built permission saving.

Skript has variables which allows the user to save the permissions themselves, removing the need for a permission plugin, as Skript becomes the permission plugin handler.

I have a popular script on Spigot, as done Shane that acts as a plugin replacement for permission plugins.

TheLimeGlass avatar Apr 07 '24 15:04 TheLimeGlass

I like the addition and the code looks good, but I'm concerned about the changes to permissions being temporary. Is there a way we can make them permanent without a ton of effort? I think users will get confused and wonder why the changes aren't lasting over restarts, no matter how much documentation we have, and with something as critical as permissions, I'm not sure that's something we should just accept.

No. The whole purpose of permission plugins is to allow for database saving. Bukkit does not have a built permission saving.

Skript has variables which allows the user to save the permissions themselves, removing the need for a permission plugin, as Skript becomes the permission plugin handler.

Hmm, makes sense. I would really like to see this work with the user's permissions plugin via hooks, if possible, but I'd accept that in a future PR too.

sovdeeth avatar Apr 07 '24 15:04 sovdeeth

Hmm, makes sense. I would really like to see this work with the user's permissions plugin via hooks, if possible, but I'd accept that in a future PR too.

You can manipulate the permissions and the permissions plugin should respect the memory list value.

TheLimeGlass avatar Apr 12 '24 19:04 TheLimeGlass

Closing due to inactivity

sovdeeth avatar Apr 07 '25 22:04 sovdeeth