Skript icon indicating copy to clipboard operation
Skript copied to clipboard

🚀 Enchantment Improvements

Open AyhamAl-Ali opened this issue 4 years ago • 1 comments

Description

This PR does the following:

  • Added support for stored enchantments for enchanted book to CondIsEnchanted, ExprEnchantments and EffEnchant classes
  • Added new expression %itemtypes% (with|of) [stored] [enchant[ment[s]]] %enchantmenttypes%
  • Added disenchanting specific enchantments
  • Also fixes (dis)enchanting multiple itemtypes causes severe error due to not handling it at all
  • Added related methods to ItemType class
  • Added has conflicting enchantments condition
  • Changed behavior of ItemType#hasEnchantments level check to != instead of < (this should be strict and level expression should be the way to check with math) - (this caused this check if player's tool is enchanted with unbreaking 1 to be true when player's tool has unbreaking 2`) Let me know if you want this to be reverted

NOTE: I couldn't find a good syntax for the new changes so if anyone have a better syntax let me know.


Target Minecraft Versions: All Requirements: None Related Issues:

  • #1496
  • #2866
  • #1836
  • #4245
  • #5530

AyhamAl-Ali avatar Oct 15 '21 16:10 AyhamAl-Ali

Might be good to add #4245 and #1234 as well

AyhamAl-Ali avatar Oct 15 '21 17:10 AyhamAl-Ali

Closing due to inactivity. Re-open if you're interested in taking it over, anyone can!

sovdeeth avatar Dec 15 '24 03:12 sovdeeth