Ethan comments

Results 91 comments of


                                            Ethan

feat: pass deserialization exceptions in gateway event handler to loop exception handler

> I think it's better to catch critical errors instead of crashing the client, because if some developers encounter a regularly appearing critical error they won't be able to ignore...

feat(app-cmds): support nsfw only commands

Given the move to "Age Restricted" #939 would it also make sense to modify "nsfw" items in this PR to the new format

fix(views): views in interaction responses

> The last attempt to save this PR is to concatenate all custom_ids of view components with the interaction ID before sending the view as an interaction response. While this...

refactor: use ffprobe even if located under /usr/bin

Hey @dotlambda, just bumping this. How are you feeling regarding the requested review comments?

refactor: use ffprobe even if located under /usr/bin

I do not necessarily agree with this for the sake of a change which may only benefit a small subset of users. Can you provide some further reasoning why the...

refactor: HTTPClient Re-Core

Regardless I also think that kind of information is too high level / frequent for `info`

refactor: HTTPClient Re-Core

> Commenting to follow PR - Waiting for resolution on > > "Nextcord waits out 429 which causes time delays for things like (Change channel name multiple times in a...

feat(WidgetMember): update display_name method to include global_name

I feel like 2 & 3 should maybe be swapped at first look, but this is a choice for others to agree or disagree with. Consider this comment an approval...

feat: add ability to format strings like text channel names

Hi @squeakerdev, just following up on this. How are you feeling on the PR regarding the review changes?

feat: support `io.StringIO` as `fp` param to `disnake.File`

Just commenting for the record, I'd also plus 1 this feature as something I use within bots to save arbitrary writes to disk