ImageSharp.Web icon indicating copy to clipboard operation
ImageSharp.Web copied to clipboard

Update shared infra and fix styles

Open stefannikolei opened this issue 7 months ago • 7 comments

stefannikolei avatar Jul 11 '25 19:07 stefannikolei

We'll need to fix the build on main first (by copying some build config from ImageSharp)

JimBobSquarePants avatar Jul 11 '25 20:07 JimBobSquarePants

We'll need to fix the build on main first (by copying some build config from ImageSharp)

And this project was still on net6

stefannikolei avatar Jul 12 '25 17:07 stefannikolei

I have updated this lib to .net8 and .net9. I had to fix some issues which were reported.

The configure method was complaining multiple things because of aot. Because this is just a lil bit of syntactic sugar i went with deleting it

stefannikolei avatar Jul 12 '25 18:07 stefannikolei

Codecov Report

:x: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 86%. Comparing base (7ecd732) to head (d9a35b7). :warning: Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...Sharp.Web/Commands/QueryCollectionRequestParser.cs 50% 1 Missing :warning:
...rc/ImageSharp.Web/Processors/ResizeWebProcessor.cs 0% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@         Coverage Diff         @@
##           main   #387   +/-   ##
===================================
  Coverage    85%    86%           
===================================
  Files        82     83    +1     
  Lines      2361   2397   +36     
  Branches    356    365    +9     
===================================
+ Hits       2023   2063   +40     
+ Misses      232    224    -8     
- Partials    106    110    +4     
Flag Coverage Δ
unittests 86% <94%> (+<1%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 12 '25 18:07 codecov[bot]

@stefannikolei I need to have a good look at this as I'm not happy with all the new required attributes. Will try my best to get on it soon.

JimBobSquarePants avatar Jul 21 '25 01:07 JimBobSquarePants

@stefannikolei I need to have a good look at this as I'm not happy with all the new required attributes. Will try my best to get on it soon.

I was not happy about that dynamicaccessedattributes either.

Those are probably from enabled aot.

We could also go the way of removing them and add istrimmable = false.

stefannikolei avatar Jul 21 '25 03:07 stefannikolei

I updated this branch.

It's still to be discussed wether to disable trimming support or keep the added attributes

stefannikolei avatar Oct 23 '25 19:10 stefannikolei