openbbm icon indicating copy to clipboard operation
openbbm copied to clipboard

Check if WAV files extraction is placed on multiple locations

Open JulissaDantes opened this issue 5 years ago • 4 comments

We had a user that claims that extracted WAV files, generated automatically by the BB Manager when a drumset is opened for editing, also get scattered around in various locations on his Mac. This is in addition to the regular BBWorkspace directory. Not sure if this is just on his system or a bug.

We could verify it by opening several drumsets in order to create a HD deficit of 1GB. If more space gets taken out, then there is an issue. If the space comes back to normal once the WAV folders are deleted from the BBWorkspace, then it should be ok.

Note: we should look if the extraction of wave files when opening a drum set is necessary for the functionality. If not, we should remove it.

JulissaDantes avatar Jun 30 '20 18:06 JulissaDantes

Likely a bug, there were some complaints about this years ago.

Thing is, "drumsets" or "kits" are made of WAV samples, and creating/editing ones means moving WAV files around (the way it's done right now, at least).

It doesn't have to be this way. Movement of WAV files does not quite need to happen unless you're importing or exporting.

iajrz avatar Jul 03 '20 14:07 iajrz

This is definitely a bug and a REALLY annoying one. The issue is this... Open a kit from a clean install and the zip files are extracted here: /user_lib/wave_sources/Standard_WAVES/

If you then decide to change a wav file and, for example, browse to: /user_lib/wave_sources/Standard_WAVES/38-Snare/111-127/YAJ-snare-13-v1-med_wet-nor-7a.wav

The next time you open a kit it's extracted here: /user_lib/wave_sources/Standard_WAVES/38-Snare/111-127/Standard_WAVES/

And so on...

The issue is so annoying that I've had a look through the code!

I think that line 194 src\drmmaker\DrumsetPanel.cpp mp_drmMakerModel = new DrmMakerModel(Workspace().userLibrary()->libWaveSources()->currentPath());

Should be: mp_drmMakerModel = new DrmMakerModel(Workspace().userLibrary()->libWaveSources()->defaultPath());

Hope this helps.

limedrop avatar Jul 09 '20 01:07 limedrop

this may be related to #145

iajrz avatar Oct 07 '20 00:10 iajrz

The issue is so annoying that I've had a look through the code!

I think that line 194 src\drmmaker\DrumsetPanel.cpp mp_drmMakerModel = new DrmMakerModel(Workspace().userLibrary()->libWaveSources()->currentPath());

Should be: mp_drmMakerModel = new DrmMakerModel(Workspace().userLibrary()->libWaveSources()->defaultPath());

Made this change in this fork

retango avatar Oct 11 '23 02:10 retango