qhexedit2 icon indicating copy to clipboard operation
qhexedit2 copied to clipboard

Please use Q_SIGNALS and Q_SLOTS in the public headers

Open kossebau opened this issue 3 months ago • 2 comments

When including the QHexEdit headers in a project which has QT_NO_KEYWORDS or QT_NO_SIGNALS_SLOTS_KEYWORDS set, this results in a build failure, as then signals and slots are no longer defined.

So would be nice if the deployed public headers are prepared for such more strict build setups.

kossebau avatar Oct 07 '25 19:10 kossebau

Bitte Pull Request

Simsys avatar Oct 09 '25 09:10 Simsys

Bitte Pull Request

Being the author of Okteta, another Qt-based hex editor (also with separate widget library), fear I cannot betray my own project more and even write code :) Just wanted, for the sake of better software for everyone, to share with you some feedback from some experiment where I have tried to use QHexEdit as replacement for the Okteta widget, as the latter currently is still not yet available for Qt6 (for complicated reasons), to try to keep its only known consumers happy while I struggle to deal with those reasons :P And possibly raise the bar for making them move back to the Okteta widget, once available #) See https://invent.kde.org/kdevelop/kdevelop/-/merge_requests/829 (and for the very issue with signals & slots here the workaround comment in plugins/gdb/memviewdlg.cpp)

kossebau avatar Oct 09 '25 12:10 kossebau