panic icon indicating copy to clipboard operation
panic copied to clipboard

Alert Step Re-Design: Implement save button instead of onChange

Open itsciccio opened this issue 3 years ago • 1 comments

Description

The delay on every update in the alerts page is too quick, causing many API calls.

Update: It has been decided to overhaul this page by implementing a Save button instead of the current onChange logic as it is the most simplistic way forward.

Requirements

~~- [ ] Extend debounce time to 2seconds.~~ ~~- [ ] Test by altering the configurations and check that the time between API calls is reasonable.~~

  • [ ] Re-design the component so to update the entire configuration with a save button
  • [ ] Test accordingly to make sure the config is updated in Mongo.

Acceptance criteria

~~Scenario: I wish to edit an alerts configuration for any sub-chain~~ ~~Given: A valid config either fresh or edited~~ ~~Then: A reasonable time between API calls~~

Scenario: Updating PANIC Configs Given: Some changes made in the page When: Save button pressed Then: Alert config saved in DB.

itsciccio avatar Oct 13 '22 14:10 itsciccio

The component is designed to update a single change at a time, as by extending the debounce will solve the original issue yet cause other issues. This page is to be converted in a way to have a Save button (similar to the sub-chain step). As for the time being, this issue will be skipped as PANIC still functions well without this change, and as a ticket it will require an overhaul for the alert setup page.

itsciccio avatar Oct 14 '22 09:10 itsciccio