determine background or extension page by `this`
Checklist
- [x] I ran the linting and formatting tools (ESLint and Prettier)
- [ ] I added addittional tests if adding new features
Closes #28
pass this instead of window into the injection anonymous function, use window.document to determine whether this is window or not, which also infers whether the page is background or extension.
Amazing, thanks! I have a few minor changes, do you mind if I commit on your branch?
No, feel free to change it
On Thu, Mar 17, 2022 at 02:22 Rushil Srivastava @.***> wrote:
Amazing, thanks! I have a few minor changes, do you mind if I commit on your branch?
— Reply to this email directly, view it on GitHub https://github.com/SimplifyJobs/webpack-ext-reloader/pull/220#issuecomment-1069415130, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADDDVG7KO3GXRI2PI4U5I3VAIRHZANCNFSM5Q3JGWWQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
-- Xiao Meng
Closing in favor of #386.