[2.1]: Notication emails for reply not sent if user also subscribe for the board

[BrickOzp]

Basic Information

If a user subscribes for notification of replies to a topic and also for new topics in the same board, notifications are not sent for the first subscription.

Steps to reproduce

1. Subscribe to a topic with email notifications
2. Subscribe to the board where the first topic is located with email notifications
3. With another user, post a reply to the topic in step 1

Expected result

Email is sent to the users subscribing to the topic.

Actual result

No email is sent to those who subscribe both to the topic and the board.

Version/Git revision

2.1.4

Database Engine

All

Database Version

10.6.17-MariaDB-cll-lve

PHP Version

7.4

Logs

The problem seems to be that the database query returns two records if the user subscribes to both the topic and the board. Only the last row will be used.

Additional Information

No response

[sbulen]

This is a dupe: https://github.com/SimpleMachines/SMF/issues/7680

Fix: https://github.com/SimpleMachines/SMF/pull/7691

[BrickOzp]

It seems that fix was included in 2.1.4 but the issue still exists for 2.1.4