SMF icon indicating copy to clipboard operation
SMF copied to clipboard

Topic notify button should close after update

Open asmith20002 opened this issue 2 years ago • 2 comments

After clicking on a topic notify button, it opens up a drop menu. After clicking on each of its items, everything updates accordingly but the menu remains open.

In theme/scripts/topic.js we have the update function:

	$('.button_strip_notify').next().find('a').click(function (e) {
		var $obj = $(this);
		e.preventDefault();
		ajax_indicator(true);
		$.get($obj.attr('href') + ';xml', function () {
			ajax_indicator(false);
			$('.button_strip_notify').text($obj.find('strong').text());
		});

		return false;
	});

Maybe add a chain? $('.button_strip_notify').text($obj.find('strong').text()); -> $('.button_strip_notify').text($obj.find('strong').text()).next('.dropmenu').hide();

asmith20002 avatar Nov 27 '23 07:11 asmith20002

I don't see why this is an issue. Feel free to customize it for your forum/theme.

DiegoAndresCortes avatar Nov 27 '23 15:11 DiegoAndresCortes

It's a design issue. After a user has decided the option they wanna go with and click on it, there's no need for the menu to remain open. It will cost the user an extra click to hide the menu.

asmith20002 avatar Nov 27 '23 15:11 asmith20002