pocket_protector icon indicating copy to clipboard operation
pocket_protector copied to clipboard

`list-all-secrets` orders domain letters instead of domains

Open graffic opened this issue 5 years ago • 2 comments

When a secret is only in one or more domains, the output is always the domain letters sorted. Example with the staging environment

$ pprotect list-all-secrets
MY_PASSWORD: a, g, i, n, s, t
  • Python 3.8.2
  • pocket_protector: git version on master.

graffic avatar Apr 14 '20 22:04 graffic

Good report, and good catch. I'd ask for a PR or to fix it myself, but it's already fixed in master! I'd suggest pip installing from the repo and trying it out, but I'm fairly confident in the fix. Will post back here when a new version is published (soon, within the next week, latest).

mahmoud avatar Apr 15 '20 18:04 mahmoud

Thank you very much @mahmoud and thank you for the fix :)

No worries about the new version, I usually install from the git repo.

graffic avatar Apr 23 '20 21:04 graffic