proxsuite icon indicating copy to clipboard operation
proxsuite copied to clipboard
verified publisher icon Simple-Robotics

ci/windows: add pipeline with MSVC compiler

Open fabinsch opened this issue 3 years ago • 2 comments

Run our CI with the default MSVC compiler as requested in #38 after the PR #33.

fabinsch avatar Oct 14 '22 15:10 fabinsch

@jcarpent windows-2022 as well is available

ahoarau avatar Oct 20 '22 16:10 ahoarau

hey @ahoarau , in our CI we are using windows-2019 (with clang) and windows-latest with MSVC, which is failing currently if you try to compile the unittest.

fabinsch avatar Oct 21 '22 11:10 fabinsch

@jcarpent this PR is now passing all our tests. The changes introduced here are:

  • additional job in .github/workflows/ci-linux-osx-win-conda.yml running on windows-latest with MSVC compiler
  • use random number generator from stdlib for MSVC instead of our own lehmer implementation
  • smaller fixes for windows specific MSVC errors
  • MSVC specific compiler flags

fabinsch avatar Oct 31 '22 14:10 fabinsch

note, I just activated again the pipelines including the the self-hosted-arm64 runner. That's why we still have 11 expected checks.

fabinsch avatar Oct 31 '22 14:10 fabinsch