Simon

Results 215 comments of Simon

@jamieu do you know if the swap has been done (ie change biography/note): > NOTE: we are hoping to have swapped the description.type['notes'] and description.type['biography'] fields in the backend systems...

We are in fact currently returning the `biography` value for the person description. - when an endpoint `/people/id/slug` (e.g; `/people/cp38764/ada-lovelace`) the `person.js` handler is called which get the data from...

After more research I think we can avoid re-indexing the database as we don't use phrase_match query but just a simple multi_match. The phrase_match query was the reason why I...

@jamieu I'm thinking of creating a new repo specifically for the synonyms to not add more maintenance features to the application itself. I think the list of synonyms will be...

The issue is due to the following function: https://github.com/TheScienceMuseum/collectionsonline/blob/master/lib/helpers/utils.js ``` module.exports = { uppercaseFirstChar: function (str) { var exclude = ['and']; if (!str) return false; return decodeURIComponent(str).split(/[\s-]/g).map(e => { if...

As mention above (https://github.com/TheScienceMuseum/collectionsonline/issues/808#issuecomment-311983321) we can first check if the application is used on mobile by checking the value of the filter position. We can't use directly `.style.position` as the...

@jamieu just a recap on this issue. I tried first to implement an easy solution: instead of letting Elasticsearch displaying the list of results by calculating the weight of each...

We are replacing spaces by "-" when building the url in the query parameter. This is to avoid having `%20`in the url (which represent spaces). This work well until the...

To allow testing via the website a category containing a "-" we need first to display more categories in the list of filter (by default elasticsearch return the 10 first...

We can first make sure that the category description is displayed. This information is taken from the json file: https://github.com/TheScienceMuseum/collectionsonline/blob/master/description-boxes/category.json So we need to make sure the keys (containing dash)...