react-native-audio-waveform icon indicating copy to clipboard operation
react-native-audio-waveform copied to clipboard

[feature]: decouple useAudioRecorder hook of WaveForm component

Open DanielFRico opened this issue 11 months ago • 3 comments

Hi team, its me! As you know in our project we are using this awesome library and we have found some improvement opportunities and of them is the option of decouple useAudioRecorder hook of WaveForm component or expose this hook as "static or separated" functionality of the WaveForm component. But why I propuse that? In our current project design we de not need to display a live WaveForm component while user is recording a note voice we just need the functionality of startRecording and stopRecording it self no more. Now, looking deeper into code I realized that I can use that useAudioRecorder hook and its functions without going through WaveForm component and used like "static" methods but what I see is that is not officially added as another option to record a note voice. Let me know what do you think about it!

DanielFRico avatar Feb 21 '25 16:02 DanielFRico

@DanielFRico Thank you for your valuable suggestion! Decoupling the useAudioRecorder hook from the WaveForm component is an interesting idea. However, implementing this would require a significant refactor of the core logic, as the hook is tightly integrated with the component.

While this is certainly achievable, it involves substantial effort. We’ll discuss this internally with the team and evaluate whether it aligns with our roadmap. That said, we welcome contributions from the community—if you’d like to work on this, feel free to submit a PR, and we’d be happy to review it!

kuldip-simform avatar Feb 24 '25 08:02 kuldip-simform

@DanielFRico Our team has started addressing the suggestions, and you can monitor the progress in this pull request: https://github.com/SimformSolutionsPvtLtd/react-native-audio-waveform/pull/174.

We value your input, so please take a look and feel free to offer any further suggestions or improvements!

kuldip-simform avatar Feb 28 '25 09:02 kuldip-simform

@DanielFRico Our team has started addressing the suggestions, and you can monitor the progress in this pull request: #174.

We value your input, so please take a look and feel free to offer any further suggestions or improvements!

@kuldip-simform Im glad to know it. Sure, if necessary I will make suggestions. Thanks

DanielFRico avatar Feb 28 '25 13:02 DanielFRico