Simen Bekkhus comments

Results 1245 comments of


                                            Simen Bekkhus

Feature request: CLI: Unset 'collectCoverageFrom' to default

we should support overriding if empty string is provided. wanna send a PR?

Add a failing test for printSnapshotAndReceived incorrectly recognizing sometimes indented lines as changed

Thanks @Andarist, failing tests are the best bug reports ever! 😀 @pedrottimark @jeysal any ideas here?

Add a failing test for printSnapshotAndReceived incorrectly recognizing sometimes indented lines as changed

Either I messed up the merge or this is fixed. @Andarist any idea? 😀

Add a failing test for printSnapshotAndReceived incorrectly recognizing sometimes indented lines as changed

I'm happy to land this as a regression test 🙂

Add a failing test for printSnapshotAndReceived incorrectly recognizing sometimes indented lines as changed

Ah wait no, the test demonstrates the error, it wasn't a _failing_ test. Makes sense! Ref https://github.com/facebook/jest/pull/9863#discussion_r413071029

Add a failing test for printSnapshotAndReceived incorrectly recognizing sometimes indented lines as changed

yeah, seems like it to me 🙂

Module loaded twice when jest.mock gets called

a reproduction without CRA would be nice 😅 there's so much extra stuff in those setups (and using very dated version of Jest)

Create a Dockerfile for contributing

sure, no reason not to, methinks. feel free to open up a PR 🙂

Use Yarn PnP

You should be able to use `resolutions` to work around it. And yeah, we'll probably ditch the browser resolve

Use Yarn PnP

thanks @nicolo-ribaudo, did that and also (tried to) fix all the other errors we get from the tsc build.