Simen Bekkhus
Simen Bekkhus
CI is failing on multiple node versions, so I don't think the version itself is the issue. Looks like a regression? (would love to land this 😀)
@olix0r ping, in case you missed it 😀 (I _may_ be able to provide a PR if you're open for it)
Can you add a test as well?
Not sure if marking as peer would solve anything, as it'd just force consumers to install the same version? making the problem of multiple versions worse
@JounQin have you seen this issue before?
@jdmarshall sorry, missed this. Mind resolving the conflict? Your new benchmark runner has also landed 🙂
I'm not allowed to push to your fork to resolve the conflict 😅
The logic lives here: https://github.com/facebook/jest/blob/0935f7c2cd7780e47365511e35efc829ba359df4/packages/jest-snapshot/src/index.ts#L132-L133 Not sure how to handle it... #8665 added the logic that if the resolved test file is ignored, then we ignore the snap file. Maybe...
That CVE is not relevant as the vulnerability was introduced in v10, and isn't present in v7. If your tooling flags it, it's faulty
Wonderful 😅