Simen Bekkhus

Results 1245 comments of Simen Bekkhus

`worker_threads` is unflagged in node 11.7.0, so the extra job isn't necessary. When (if) we land #7681 I'll update this PR to remove all the `disableWorkerThreads: true` and see where...

Circle has node 11.8 now, which has the `umask` fix. Rebased, hopefully a better result this time 🙂

I wanna see that tests pass without being stupidly slow first. If they do, then we can test by actually spinning up workers 🙂 These have to be fixed first:...

haha, it just died 😛 But looking at, and fixing, `multiProjectRunner` might be what we're missing. If anybody wants to pick it up

Test failures on node 12, that's odd...

whatever that old issue was, it seems to have been fixed 👍 ![image](https://user-images.githubusercontent.com/1404810/68541332-62787900-039e-11ea-82d2-c438564cfbc5.png) Will need to look into why coverage fails, but this is super promising

Very interesting - tests fail on circus, but passes on GH Actions. The failing test on CI passes on my local machine. Very odd...

@sibelius very interested in hearing numbers if you play with - does it impact memory/cpu usage?

I added a quick and dirty `produceCachedData`, and it went down to about `180 ms`. Which is a great improvement, albeit still 5x slower than `new Script`. And harder to...

In Jest's case we'll be passing a different `parsingContext` all the time (Jest uses a different `Context` per test file for sandboxing), so if the cached data is dependent on...