RPGStats icon indicating copy to clipboard operation
RPGStats copied to clipboard

Would like support for hammers added by Vanilla Hammers, etc.

Open DraigRygbi opened this issue 4 years ago • 7 comments

https://www.curseforge.com/minecraft/mc-mods/vanilla-hammers

DraigRygbi avatar Jul 27 '21 16:07 DraigRygbi

What needs compatibility?

SilverAndro avatar Jul 27 '21 16:07 SilverAndro

I don't seem to be getting any mining XP while using hammers.

On Tue, Jul 27, 2021 at 12:43 PM P03W @.***> wrote:

What needs compatibility?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/P03W/RPGStats/issues/70#issuecomment-887666945, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA26NGSIBMQ4YBTJZE4JNTTZ3O4PANCNFSM5BCTFTIA .

DraigRygbi avatar Jul 27 '21 16:07 DraigRygbi

Can you provide a log of you mining ores with the debug options enabled in the config?

SilverAndro avatar Jul 27 '21 16:07 SilverAndro

Nothing shows up in the log when I'm mining the ores with the hammer, only with a pickaxe. Between giving myself the hammer and giving myself the pickaxe, I mined several ores with the hammer. It recognizes the pickaxe but not the hammer.

[13:29:19] [Server thread/INFO]: [RugbyRaizel: Gave 1 [Adamantium Hammer] to RugbyRaizel] [13:29:19] [Render thread/INFO]: [CHAT] Gave 1 [Adamantium Hammer] to RugbyRaizel [13:29:35] [Server thread/INFO]: RugbyRaizel has made the advancement [The Strongest Pick] [13:29:35] [Server thread/INFO]: [RugbyRaizel: Gave 1 [Adamantium Pickaxe] to RugbyRaizel] [13:29:35] [Render thread/INFO]: [CHAT] RugbyRaizel has made the advancement [The Strongest Pick] [13:29:35] [Render thread/INFO]: [CHAT] Gave 1 [Adamantium Pickaxe] to RugbyRaizel [13:29:35] [Render thread/INFO]: Loaded 48 advancements [13:29:38] [Render thread/INFO]: Loaded 49 advancements [13:29:43] [Server thread/INFO]: RugbyRaizel broke block.minecraft.stone [13:29:44] [Server thread/INFO]: RugbyRaizel broke block.minecraft.stone [13:29:44] [Server thread/INFO]: RugbyRaizel broke block.minecraft.stone

DraigRygbi avatar Jul 27 '21 17:07 DraigRygbi

Ill look into it but I dont think I can do much

The issue seems to be them not firing the block break event

SilverAndro avatar Jul 27 '21 17:07 SilverAndro

The compatibility would need to be with Hammers library, Magna

itsdinkd avatar Sep 11 '21 18:09 itsdinkd

@red2blue please see Draylar/vanilla-hammers#98 where I mentioned I use the fabric API event, so unless magna inst calling that event properly it should work

SilverAndro avatar Sep 11 '21 18:09 SilverAndro