specification icon indicating copy to clipboard operation
specification copied to clipboard
verified publisher icon SignalK

Add "arrivalCircle" to "nextPoint"

Open panaaj opened this issue 4 years ago • 3 comments

Addition of arrivalCircle to nextPoint to allow an arrival alarm to be implemented.

panaaj avatar Oct 23 '21 06:10 panaaj

Added tests for nextPoint.arrivalCircle. I have noticed two things in the test data that don't align with the text in the proposed CourseAPI.

  1. href test value is under vessels ("href": "/vessels/vessels.urn:mrn:imo:mmsi:230099999/resources/waypoints/...") when in practice resources is at the root of ./signalk/v1/api.
  2. arrivalCircleEntered notification is defined as notifications.arrivalCircleEntered where the proposed notification path in the Course API PR is notifications.navigation.course.arrivalCircleEntered

Should these be updated in the test file?

panaaj avatar Oct 31 '21 23:10 panaaj

I'll merge this, submit a new PR for fixes?

tkurki avatar Nov 03 '21 18:11 tkurki

Oh, please rebase. Would do it myself nicely if the branch were under this repo ;-)

tkurki avatar Nov 03 '21 18:11 tkurki