web-configs icon indicating copy to clipboard operation
web-configs copied to clipboard

Add missing peer dependencies in eslint-plugin and stylelint-plugin

Open matwilko opened this issue 2 years ago • 2 comments

Description

@shopify/eslint-plugin and @shopify/stylelint-plugin are missing peerDependencies on @babel/core and prettier.

While it's not a massive problem, it does make life harder for package managers when trying to optimize package installation, see Implicit Transitive Peer Dependencies.

yarn currently reports both of these packages as missing peer dependencies:

➤ YN0000: @shopify/eslint-plugin@npm:42.1.0 doesn't provide @babel/core, breaking the following requirements:
➤ YN0000: @babel/eslint-parser@npm:7.22.9 → >=7.11.0

➤ YN0000: @shopify/eslint-plugin@npm:42.1.0 doesn't provide prettier, breaking the following requirements:
➤ YN0000: eslint-plugin-prettier@npm:4.2.1 → >=2.0.0

➤ YN0000: @shopify/stylelint-plugin@npm:12.0.1 doesn't provide prettier, breaking the following requirements:
➤ YN0000: stylelint-prettier@npm:3.0.0 → >=2.0.0

Noted both changes as patch, because consumers will already have been required to fulfil these requirements, so it's not forcing them to upgrade or install new packages with potential breaking changes.

matwilko avatar Jul 25 '23 19:07 matwilko

Note: I know the CLA needs signing, it just requires internal approval first, should only be a few days :)

matwilko avatar Jul 25 '23 19:07 matwilko

I have signed the CLA!

matwilko avatar Aug 03 '23 22:08 matwilko