Misleading messages from theme watch

[tms320c]

Describe the bug theme watch reports about files which it is supposed to ignore. The files are not uploaded, just reported.

To Reproduce Steps to reproduce the behavior:

1. project contains CSS and JS sources (to be compiled) in subdirectories of ./assets directory
2. config.yml contains the directive to ignore that subdirectories (e.g. ignore_files: assets/sass/)
3. theme watch
4. modify a source file (e.g. theme.scss)
5. see "07:47:45 [development] processing assets/sass/theme.scss" and
6. "[development] (assets/sass/theme.scss) Theme files may not be stored in subfolders"

Expected behavior No messages regarding the files/folders which are ignored by configuration.

Environment (please complete the following information):

• Win10
• Themekit version [e.g. v0.7.5]: ThemeKit 1.0.1 windows/amd64
• Editor [e.g. atom, sublime]: notepad++
• Ignore: in config.yml

Additional context Config.yml

development:
  password: *************************
  theme_id: "********************"
  store: **********.myshopify.com
  ignore_files:
  - .git/
  - node_modules/
  - assets/js/
  - assets/sass/
  - .gitignore
  - package.json
  - yarn.lock
  - webpack.config.js
  - .babelrc
  - .eslintignore
  - .eslintrc.json
  proxy: ************
  timeout: 1m0s

[tanema]

Hey @tms320c thanks for reporting this. That message indicates that themekit is actually not ignoring those files, and the Theme files may not be stored in subfolders is coming from shopify. I will look into why those files are not being ignored.

Edit: I see now that you are on windows and it might be likely that the ignore paths are not handled in a universal way, I will check, but you can also test this by adding assets\sass\ to your ignores list and see if it works.

[tanema]

Also, unrelated question but can I ask why you are using a proxy?

[tanema]

Okay I did confirm that this is a problem with file filters on windows in the newest version. I will hopefully have the new version out soon.

[tms320c]

Hi, I use a proxy because of the messed IP-fitlering implemented by the provider. They block some bad guys but sometimes the good guys are inside the same address ranges. So, I build the proxy hosted by a "good guy" and use it as a habit. Perhaps, it is not necessary in this particular case.

Just to clarify - the files are really ignored and when I run "theme deploy" everything is fine, exactly as configured and without any warnings.

[tanema]

I see also you are running an old version of themekit. Can you please update and try again?