Shopify
Added doc tag support logic inside snippet tag
What are you adding in this PR?
Solves #826
Updated theme check to support doc tag inside of snippet tag. This change allows the doc tag to be used within inline snippets, in addition to the previously supported snippet and block contexts.
This PR also makes the theme check more rigorous by ensuring the doc tag is either:
- at the top level of a snippet/block file, OR
- a direct child of the snippet tag
The error message has been updated to reflect this new support, and tests have been added to verify that doc tags inside inline snippets don't trigger errors.
What's next? Any followup issues?
Update the theme check docs
Before you deploy
- [x] This PR includes a new checks or changes the configuration of a check
- [x] I included a minor bump
changeset - [ ] I've made a PR to update the shopify.dev theme check docs if applicable.
[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more
-
#1072
: 2 dependent PRs (#1068 , #1074 ) 👈 (View in Graphite)
-
#1071
-
#1063 : 1 other dependent PR (#1069 )
-
main
This stack of pull requests is managed by Graphite. Learn more about stacking.