theme-scripts icon indicating copy to clipboard operation
theme-scripts copied to clipboard

webpack warning: theme-product-form has incorrect peer dependency

Open tms320c opened this issue 6 years ago • 4 comments

Webpack reports a warning:

@shopify/[email protected]" has incorrect peer dependency "@shopify/theme-product@^1.0.0"

tms320c avatar Aug 01 '19 18:08 tms320c

I am seeing this issue as well which is actually starting to throw errors for the latest version of NPM (7.5.2).

It would be good if the latest version of theme-product-form (currently 4.1.0) required a more up to date version of the package (maybe 3.0.0) as if you need both the packages, you can only have the version 1 of theme-product.

hugoburguete avatar Feb 03 '21 12:02 hugoburguete

It looks like there is a Pull Request for this already - https://github.com/Shopify/theme-scripts/pull/138 can someone push it through?

richayles avatar Feb 05 '21 12:02 richayles

@chrisberthe Although the PR has been merged, the error is still present. Looking at the node_modules folder, I can confirm I have the latest version of the package but the peer dependency hasn't been updated.

image

Could this be an update needed in NPM's side?

EDIT: Possibly an update in the 4.1.0 tag would fix this: https://github.com/Shopify/theme-scripts/blob/v4.1.0/packages/theme-product-form/package.json

hugoburguete avatar Mar 09 '21 12:03 hugoburguete

Hi, the update is now published via npm

Let me know if there's anything else. Thank you

tauthomas01 avatar Mar 15 '21 19:03 tauthomas01