theme-check icon indicating copy to clipboard operation
theme-check copied to clipboard

Fail on theme check

Open ivandurst opened this issue 2 years ago • 2 comments

Stack trace

Theme check failed with error:
┃ /Users/ivandurst/Library/Caches/shopify-gems-nodejs/ruby/3.2.0/gems/theme-check-1.15.0/lib/theme_check/bug.rb:20:in `bug': Can't find a parseable tag of name img inside the parseable HTML. (ThemeCheck::ThemeCheckError)
┃ 
┃ Tag name:
┃   "img"
┃ 
┃ File:
┃   snippets/template-banner.liquid
┃ 
┃ Line number:
┃   10
┃ 
┃ Excerpt:
┃   ```
┃   image: <image object>
┃ mobile_image: <image object>
┃ mobile_crop: <string>
┃ banner_pretext: <string>
┃ banner_text: <string>
┃ banner_subheading: <string>
┃ 
┃   ```
┃ 
┃ Parseable Excerpt:
┃   ```
┃   image: <image object>
┃ mobile_image: <image object>
┃ mobile_crop: <string>
┃ banner_pretext: <string>
┃ banner_text: <string>
┃ banner_subheading: <string>
┃ 
┃   ```
┃ Theme Check Version: 1.15.0
┃ Ruby Version: 3.2.2
┃ Platform: x86_64-darwin21
┃ Muffin mode: activated

Debugging information

  • Mac Monterey
  • Version 1.15.0

ivandurst avatar Jul 25 '23 17:07 ivandurst

+1 for me. I ran 'shopify theme check'. But I'm on Mac Sonoma 14.0 and version 3

Possibly related? https://github.com/Shopify/theme-check/issues/711

chufucious avatar Dec 29 '23 00:12 chufucious

👋🏻 Hi @chufucious! Thanks for reporting this. Unfortunately the Ruby version of theme check has been deprecated for some time. Would you be able to confirm you are still having issues when using our maintained version of theme check? This is done using either the latest version of the Shopify CLI, or via the Shopify Liquid Visual Studio Code extension.

If you are still having issues, please raise an issue over in the CLI or theme tools repositories. Thanks!

lukeh-shopify avatar Jul 12 '24 22:07 lukeh-shopify